Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

org/talika/jsm/DatabaseSecurityModule.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - java.security.*.	25
	Using the '.*' form of import should be avoided - java.sql.*.	26
	Using the '.*' form of import should be avoided - javax.sql.*.	27
	Unclosed HTML tag found: <josem@talika.org>	35
	Line has trailing spaces.	38
	'{' should be on the previous line.	40
	First sentence should end with a period.	42
	Parameter ds should be final.	43
	Expected @param tag for 'ds'.	43
	Method 'getPrincipal' is not designed for extension - needs to be abstract, final or empty.	47
	Missing a Javadoc comment.	47
	Parameter principal should be final.	47
	Line has trailing spaces.	50
	Method 'doesUserHaveRole' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Parameter principal should be final.	51
	Parameter roles should be final.	51
	Line has trailing spaces.	52
	Line has trailing spaces.	53
	Line has trailing spaces.	54
	'if' is not followed by whitespace.	55
	Line has trailing spaces.	56
	Line has trailing spaces.	58
	Line has trailing spaces.	60
	Line is longer than 80 characters.	62
	',' is not followed by whitespace.	63
	Line has trailing spaces.	65
	'while' is not followed by whitespace.	66
	Line has trailing spaces.	67
	'if' construct must use '{}'s.	69
	Line has trailing spaces.	71
	Line has trailing spaces.	73
	Line has trailing spaces.	76
	'}' should be on the same line.	77
	'catch' is not followed by whitespace.	78
	'}' should be on the same line.	80
	Line has trailing spaces.	82
	'if' construct must use '{}'s.	84
	'}' should be on the same line.	85
	Must have at least one statement.	86
	'{' is not followed by whitespace.	86
	'}' is not preceded with whitespace.	86
	Line has trailing spaces.	87
	Line has trailing spaces.	88
	Line has trailing spaces.	89
	Line has trailing spaces.	91
	Line has trailing spaces.	93
	Line has trailing spaces.	95
	Method 'isValid' is not designed for extension - needs to be abstract, final or empty.	96
	Missing a Javadoc comment.	96
	Parameter principal should be final.	96
	Parameter credential should be final.	96
	Line has trailing spaces.	97
	Line has trailing spaces.	99
	'if' is not followed by whitespace.	100
	Line has trailing spaces.	101
	Line has trailing spaces.	103
	Line has trailing spaces.	105
	Line is longer than 80 characters.	107
	',' is not followed by whitespace.	108
	Line has trailing spaces.	110
	'if' is not followed by whitespace.	111
	Line has trailing spaces.	112
	Line has trailing spaces.	113
	Line is longer than 80 characters.	113
	'if' construct must use '{}'s.	114
	'if' is not followed by whitespace.	114
	Line has trailing spaces.	116
	Line has trailing spaces.	118
	Line has trailing spaces.	121
	'}' should be on the same line.	122
	'catch' is not followed by whitespace.	123
	'}' should be on the same line.	125
	Line has trailing spaces.	127
	'if' construct must use '{}'s.	129
	'}' should be on the same line.	130
	Must have at least one statement.	131
	'{' is not followed by whitespace.	131
	'}' is not preceded with whitespace.	131
	Line has trailing spaces.	132
	Line has trailing spaces.	133
	Line has trailing spaces.	134
	Line has trailing spaces.	136
	Line has trailing spaces.	138
	Line has trailing spaces.	140
	Missing a Javadoc comment.	141
	Name '_ds' must match pattern '^[a-z][a-zA-Z0-9]*$'.	141
	Line has trailing spaces.	142
	Missing a Javadoc comment.	143
	'static' modifier out of order with the JLS suggestions.	143
	Missing a Javadoc comment.	144
	'static' modifier out of order with the JLS suggestions.	144
	Missing a Javadoc comment.	145
	'static' modifier out of order with the JLS suggestions.	145
	Missing a Javadoc comment.	146
	'static' modifier out of order with the JLS suggestions.	146
	Missing a Javadoc comment.	147
	'static' modifier out of order with the JLS suggestions.	147
	Line has trailing spaces.	148
	Line has trailing spaces.	149
	Missing a Javadoc comment.	149
	'static' modifier out of order with the JLS suggestions.	149
	Line is longer than 80 characters.	150
	'+' is not followed by whitespace.	150
	Line has trailing spaces.	151
	Missing a Javadoc comment.	151
	'static' modifier out of order with the JLS suggestions.	151
	Line is longer than 80 characters.	152
	'+' is not followed by whitespace.	152
	Line has trailing spaces.	153

org/talika/jsm/DatabaseSecurityModuleService.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - javax.naming.*.	26
	Using the '.*' form of import should be avoided - javax.naming.spi.*.	27
	Using the '.*' form of import should be avoided - javax.management.*.	28
	Using the '.*' form of import should be avoided - javax.sql.*.	29
	Unclosed HTML tag found: <josem@talika.org>	35
	Line is longer than 80 characters.	38
	Line has trailing spaces.	40
	Missing a Javadoc comment.	41
	Line has trailing spaces.	43
	Missing a Javadoc comment.	44
	Parameter name should be final.	44
	Parameter dsName should be final.	44
	Line has trailing spaces.	48
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	49
	Missing a Javadoc comment.	49
	'{' should be on the previous line.	50
	Line has trailing spaces.	53
	Method 'getObjectName' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Parameter server should be final.	54
	'server' hides a field.	54
	Parameter name should be final.	54
	'{' should be on the previous line.	56
	Line has trailing spaces.	60
	Missing a Javadoc comment.	61
	Line has trailing spaces.	63
	'{' should be on the previous line.	63
	Line has trailing spaces.	66
	Method 'startService' is not designed for extension - needs to be abstract, final or empty.	67
	Missing a Javadoc comment.	67
	'{' should be on the previous line.	69
	'if' is not followed by whitespace.	71
	Line has trailing spaces.	72
	'if' construct must use '{}'s.	73
	'if' is not followed by whitespace.	73
	'if' construct must use '{}'s.	74
	'if' is not followed by whitespace.	74
	Line has trailing spaces.	75
	Line has trailing spaces.	77
	Line has trailing spaces.	79
	Line has trailing spaces.	80
	Line has trailing spaces.	81
	Line has trailing spaces.	88
	Line is longer than 80 characters.	90
	Line has trailing spaces.	91
	Line has trailing spaces.	93
	Line has trailing spaces.	94
	'}' should be on the same line.	95
	'catch' is not followed by whitespace.	96
	Line has trailing spaces.	99
	Line has trailing spaces.	100
	Line has trailing spaces.	103
	Line has trailing spaces.	105
	Line has trailing spaces.	106
	Line has trailing spaces.	107
	Line has trailing spaces.	108
	Method 'stopService' is not designed for extension - needs to be abstract, final or empty.	109
	Missing a Javadoc comment.	109
	'{' should be on the previous line.	110
	'{' should be on the previous line.	112
	'}' should be on the same line.	115
	Must have at least one statement.	116
	'}' should be on the same line.	117
	'{' should be on the previous line.	119
	Line has trailing spaces.	123
	Missing a Javadoc comment.	124
	'{' should be on the previous line.	125
	Line has trailing spaces.	126
	Line has trailing spaces.	128
	Line is longer than 80 characters.	129
	Method 'getObjectInstance' is not designed for extension - needs to be abstract, final or empty.	129
	Missing a Javadoc comment.	129
	Parameter obj should be final.	129
	Parameter name should be final.	129
	Parameter nameCtx should be final.	129
	Parameter environment should be final.	129
	'{' should be on the previous line.	131
	'-' is not preceded with whitespace.	132
	'-' is not followed by whitespace.	132
	Line has trailing spaces.	134
	Method 'setInstanceName' is not designed for extension - needs to be abstract, final or empty.	135
	Missing a Javadoc comment.	135
	Parameter name should be final.	135
	Line has trailing spaces.	138
	Method 'getInstanceName' is not designed for extension - needs to be abstract, final or empty.	139
	Missing a Javadoc comment.	139
	Line has trailing spaces.	142
	Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty.	143
	Missing a Javadoc comment.	143
	Parameter name should be final.	143
	Line has trailing spaces.	146
	Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty.	147
	Missing a Javadoc comment.	147
	Line has trailing spaces.	150
	Missing a Javadoc comment.	152
	Missing a Javadoc comment.	153
	Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'.	153
	Missing a Javadoc comment.	154
	Name '_dsName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	154
	Line has trailing spaces.	155
	Missing a Javadoc comment.	155
	Line has trailing spaces.	156
	Missing a Javadoc comment.	157
	Line has trailing spaces.	158
	Missing a Javadoc comment.	160
	Name 'JNDI_NAME_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	160
	Variable 'JNDI_NAME_PREFIX' must be private and have accessor methods.	160
	Line has trailing spaces.	161

org/talika/jsm/DatabaseSecurityModuleServiceMBean.java

Error		Line
	Missing a header - not enough lines in file.	1
	Unclosed HTML tag found: <josem@talika.org>	27
	Line is longer than 80 characters.	30
	Line has trailing spaces.	32
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	33
	Line has trailing spaces.	34
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34
	Missing a Javadoc comment.	35
	Redundant 'public' modifier.	35
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Line has trailing spaces.	39

org/talika/jsm/LDAPSecurityModule.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - java.security.*.	25
	Using the '.*' form of import should be avoided - javax.naming.*.	26
	Using the '.*' form of import should be avoided - javax.naming.directory.*.	27
	Unclosed HTML tag found: <josem@talika.org>	36
	'{' should be on the previous line.	40
	First sentence should end with a period.	42
	Parameter ctx should be final.	43
	Expected @param tag for 'ctx'.	43
	Parameter searchBase should be final.	43
	Expected @param tag for 'searchBase'.	43
	Line has trailing spaces.	46
	Line has trailing spaces.	47
	Method 'getPrincipal' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Parameter principal should be final.	50
	Line has trailing spaces.	53
	Method 'doesUserHaveRole' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Parameter principal should be final.	54
	Parameter roles should be final.	54
	Line has trailing spaces.	55
	Line has trailing spaces.	57
	'if' is not followed by whitespace.	58
	Line has trailing spaces.	59
	Line has trailing spaces.	61
	'if' is not followed by whitespace.	63
	Line has trailing spaces.	64
	'if' is not followed by whitespace.	66
	'if' is not followed by whitespace.	69
	Line has trailing spaces.	70
	'while' is not followed by whitespace.	72
	Line has trailing spaces.	73
	'if' construct must use '{}'s.	75
	Line has trailing spaces.	77
	Line has trailing spaces.	81
	Line has trailing spaces.	83
	'}' should be on the same line.	84
	'catch' is not followed by whitespace.	85
	Line has trailing spaces.	90
	Line has trailing spaces.	92
	Line has trailing spaces.	94
	Method 'isValid' is not designed for extension - needs to be abstract, final or empty.	95
	Missing a Javadoc comment.	95
	Parameter principal should be final.	95
	Parameter credential should be final.	95
	Line has trailing spaces.	96
	Line has trailing spaces.	98
	'if' is not followed by whitespace.	99
	Line has trailing spaces.	100
	Line has trailing spaces.	102
	'if' is not followed by whitespace.	104
	Line has trailing spaces.	105
	'if' construct must use '{}'s.	108
	'if' is not followed by whitespace.	108
	Line has trailing spaces.	110
	Line has trailing spaces.	111
	Line has trailing spaces.	113
	Line has trailing spaces.	116
	'}' should be on the same line.	120
	'catch' is not followed by whitespace.	121
	Must have at least one statement.	121
	Line has trailing spaces.	122
	Line has trailing spaces.	124
	'}' should be on the same line.	125
	'catch' is not followed by whitespace.	126
	Line has trailing spaces.	129
	Line has trailing spaces.	131
	Line has trailing spaces.	133
	Line has trailing spaces.	135
	Line is longer than 80 characters.	136
	Missing a Javadoc comment.	136
	Parameter principal should be final.	136
	Line has trailing spaces.	137
	Line has trailing spaces.	138
	Line has trailing spaces.	142
	Line is longer than 80 characters.	144
	'+' is not preceded with whitespace.	144
	'+' is not followed by whitespace.	144
	'+' is not preceded with whitespace.	144
	'+' is not followed by whitespace.	144
	'+' is not preceded with whitespace.	144
	'+' is not followed by whitespace.	144
	'+' is not preceded with whitespace.	144
	'+' is not followed by whitespace.	144
	',' is not followed by whitespace.	144
	'if' is not followed by whitespace.	145
	'}' should be on the same line.	147
	'else' construct must use '{}'s.	148
	Line has trailing spaces.	150
	Line has trailing spaces.	152
	Missing a Javadoc comment.	153
	Name '_ctx' must match pattern '^[a-z][a-zA-Z0-9]*$'.	153
	Missing a Javadoc comment.	154
	Name '_url' must match pattern '^[a-z][a-zA-Z0-9]*$'.	154
	Missing a Javadoc comment.	155
	Name '_user' must match pattern '^[a-z][a-zA-Z0-9]*$'.	155
	Missing a Javadoc comment.	156
	Name '_password' must match pattern '^[a-z][a-zA-Z0-9]*$'.	156
	Line has trailing spaces.	157
	Missing a Javadoc comment.	157
	Name '_searchBase' must match pattern '^[a-z][a-zA-Z0-9]*$'.	157
	Line has trailing spaces.	158
	Missing a Javadoc comment.	159
	'static' modifier out of order with the JLS suggestions.	159
	Missing a Javadoc comment.	160
	'static' modifier out of order with the JLS suggestions.	160
	Missing a Javadoc comment.	161
	'static' modifier out of order with the JLS suggestions.	161
	Missing a Javadoc comment.	163
	'static' modifier out of order with the JLS suggestions.	163
	Line has trailing spaces.	164

org/talika/jsm/LDAPSecurityModuleService.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - javax.naming.*.	27
	Using the '.*' form of import should be avoided - javax.naming.directory.*.	28
	Using the '.*' form of import should be avoided - javax.naming.spi.*.	29
	Using the '.*' form of import should be avoided - javax.management.*.	30
	Unclosed HTML tag found: <josem@talika.org>	36
	Line is longer than 80 characters.	39
	Line has trailing spaces.	41
	Missing a Javadoc comment.	42
	Line is longer than 80 characters.	45
	Missing a Javadoc comment.	45
	Parameter name should be final.	45
	Parameter url should be final.	45
	Parameter bindDN should be final.	45
	Parameter passwd should be final.	45
	Parameter searchBase should be final.	45
	Line has trailing spaces.	52
	Method 'getName' is not designed for extension - needs to be abstract, final or empty.	53
	Missing a Javadoc comment.	53
	'{' should be on the previous line.	54
	Line has trailing spaces.	57
	Method 'getObjectName' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58
	Parameter server should be final.	58
	'server' hides a field.	58
	Parameter name should be final.	58
	'{' should be on the previous line.	60
	Line has trailing spaces.	64
	Missing a Javadoc comment.	65
	'{' should be on the previous line.	67
	Line has trailing spaces.	69
	Method 'startService' is not designed for extension - needs to be abstract, final or empty.	70
	Missing a Javadoc comment.	70
	'{' should be on the previous line.	72
	Line has trailing spaces.	73
	'if' is not followed by whitespace.	75
	Line has trailing spaces.	76
	'if' construct must use '{}'s.	77
	'if' is not followed by whitespace.	77
	'if' construct must use '{}'s.	78
	'if' is not followed by whitespace.	78
	'if' construct must use '{}'s.	79
	'if' is not followed by whitespace.	79
	Line has trailing spaces.	80
	Line has trailing spaces.	82
	Line has trailing spaces.	84
	Line has trailing spaces.	86
	Line is longer than 80 characters.	89
	'if' construct must use '{}'s.	91
	'if' is not followed by whitespace.	91
	'if' construct must use '{}'s.	92
	Line has trailing spaces.	92
	Line is longer than 80 characters.	92
	'if' is not followed by whitespace.	92
	Line has trailing spaces.	94
	Line has trailing spaces.	95
	Line has trailing spaces.	97
	Line is longer than 80 characters.	99
	Line has trailing spaces.	100
	Line has trailing spaces.	102
	Line has trailing spaces.	103
	'}' should be on the same line.	104
	'catch' is not followed by whitespace.	105
	Line has trailing spaces.	108
	Line has trailing spaces.	109
	Line has trailing spaces.	112
	'if' construct must use '{}'s.	116
	'if' is not followed by whitespace.	116
	'if' construct must use '{}'s.	117
	'if' is not followed by whitespace.	117
	Line has trailing spaces.	118
	Line has trailing spaces.	119
	Line has trailing spaces.	120
	Method 'stopService' is not designed for extension - needs to be abstract, final or empty.	121
	Missing a Javadoc comment.	121
	'{' should be on the previous line.	122
	'{' should be on the previous line.	124
	'}' should be on the same line.	127
	Must have at least one statement.	128
	'}' should be on the same line.	129
	'{' should be on the previous line.	131
	Line has trailing spaces.	135
	Missing a Javadoc comment.	136
	'{' should be on the previous line.	137
	Line has trailing spaces.	138
	Line has trailing spaces.	139
	Line is longer than 80 characters.	140
	Method 'getObjectInstance' is not designed for extension - needs to be abstract, final or empty.	140
	Missing a Javadoc comment.	140
	Parameter obj should be final.	140
	Parameter name should be final.	140
	Parameter nameCtx should be final.	140
	Parameter environment should be final.	140
	'{' should be on the previous line.	142
	'-' is not preceded with whitespace.	143
	'-' is not followed by whitespace.	143
	Line has trailing spaces.	145
	Method 'setInstanceName' is not designed for extension - needs to be abstract, final or empty.	146
	Missing a Javadoc comment.	146
	Parameter name should be final.	146
	Method 'getInstanceName' is not designed for extension - needs to be abstract, final or empty.	150
	Missing a Javadoc comment.	150
	Line has trailing spaces.	153
	Method 'setUrl' is not designed for extension - needs to be abstract, final or empty.	154
	Missing a Javadoc comment.	154
	Parameter url should be final.	154
	Line has trailing spaces.	157
	Method 'getUrl' is not designed for extension - needs to be abstract, final or empty.	158
	Missing a Javadoc comment.	158
	Line has trailing spaces.	161
	Method 'setBindDN' is not designed for extension - needs to be abstract, final or empty.	162
	Missing a Javadoc comment.	162
	Parameter bindDN should be final.	162
	Line has trailing spaces.	165
	Method 'getBindDN' is not designed for extension - needs to be abstract, final or empty.	166
	Missing a Javadoc comment.	166
	Line has trailing spaces.	169
	Method 'setPassword' is not designed for extension - needs to be abstract, final or empty.	170
	Missing a Javadoc comment.	170
	Parameter password should be final.	170
	Line has trailing spaces.	173
	Method 'getPassword' is not designed for extension - needs to be abstract, final or empty.	174
	Missing a Javadoc comment.	174
	Line has trailing spaces.	177
	Method 'setSearchBase' is not designed for extension - needs to be abstract, final or empty.	178
	Missing a Javadoc comment.	178
	Parameter searchBase should be final.	178
	Line has trailing spaces.	181
	Method 'getSearchBase' is not designed for extension - needs to be abstract, final or empty.	182
	Missing a Javadoc comment.	182
	Line has trailing spaces.	185
	Line has trailing spaces.	187
	Missing a Javadoc comment.	187
	Missing a Javadoc comment.	188
	Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'.	188
	Missing a Javadoc comment.	189
	Name '_url' must match pattern '^[a-z][a-zA-Z0-9]*$'.	189
	Missing a Javadoc comment.	190
	Name '_bindDN' must match pattern '^[a-z][a-zA-Z0-9]*$'.	190
	Missing a Javadoc comment.	191
	Name '_passwd' must match pattern '^[a-z][a-zA-Z0-9]*$'.	191
	Missing a Javadoc comment.	192
	Name '_searchBase' must match pattern '^[a-z][a-zA-Z0-9]*$'.	192
	Missing a Javadoc comment.	193
	Line has trailing spaces.	194
	Missing a Javadoc comment.	195
	Line has trailing spaces.	196
	Missing a Javadoc comment.	198
	Name 'JNDI_NAME_PREFIX' must match pattern '^[a-z][a-zA-Z0-9]*$'.	198
	Variable 'JNDI_NAME_PREFIX' must be private and have accessor methods.	198
	Line has trailing spaces.	199

org/talika/jsm/LDAPSecurityModuleServiceMBean.java

Error		Line
	Missing a header - not enough lines in file.	1
	Unclosed HTML tag found: <josem@talika.org>	27
	Line is longer than 80 characters.	30
	Line has trailing spaces.	32
	Missing a Javadoc comment.	33
	Redundant 'public' modifier.	33
	Missing a Javadoc comment.	34
	Redundant 'public' modifier.	34
	Missing a Javadoc comment.	35
	Redundant 'public' modifier.	35
	Missing a Javadoc comment.	36
	Redundant 'public' modifier.	36
	Missing a Javadoc comment.	37
	Redundant 'public' modifier.	37
	Missing a Javadoc comment.	38
	Redundant 'public' modifier.	38
	Missing a Javadoc comment.	39
	Redundant 'public' modifier.	39
	Missing a Javadoc comment.	40
	Redundant 'public' modifier.	40
	Missing a Javadoc comment.	41
	Redundant 'public' modifier.	41
	Missing a Javadoc comment.	42
	Redundant 'public' modifier.	42
	Missing a Javadoc comment.	44
	Redundant 'public' modifier.	44
	Line has trailing spaces.	45

org/talika/jsm/package.html

Error		Line
	Missing package documentation file.	0